Index

Show enters and exits. Hide enters and exits.

01:24:51smt6kHi
17:29:48brixenmorning
17:29:57brixensaywatmang: I'll commit the patch shortly
17:30:18brixensaywatmang: I was trying to fix some mathn related nonsense
18:14:11saywatmangkewl np
18:16:30brixensaywatmang: ok, just running the full specs before pushing
18:16:45brixensaywatmang: I know I'm picky on the specs, but given the thousands of them, I have to be
18:16:59brixenthere are still so many places in rubyspec that just make me want to weep
18:17:05brixenthey are so hard to understand
18:25:11BrianRice-workwhy is that?
18:26:01brixenBrianRice-work: why is what?
18:26:34BrianRice-workoh, just what makes a rubyspec hard to grok
18:26:46brixenthere is some very poor quality
18:26:50BrianRice-workok
18:27:05brixenin general, it is often the case that people do not consider code in tests/specs to be "real code"
18:27:20brixenand I allowed a lot of code into rubyspec in the interests of getting coverage
18:27:27brixenthat was of poor quality
18:27:37brixenhow poor I've only started to realize lately
18:27:41brixenunfortunately :(
18:28:15brixenso now I'm trying to tighten the reins, which is always the wrong way to go
18:28:25brixenleads to much bucking and whining ;)
18:28:40BrianRice-workI see
18:32:00saywatmangyea, totally understand
18:32:32brixensaywatmang: I pushed to rubyspec repo, I'm sync'ing with rbx now
18:48:21brixenugh, like these File#expand_path specs
18:48:23brixen:(
18:50:07brixenyes, of course, I've already annotated them: # FIXME: these are insane!
18:50:47brixenunless not home = ENV['HOME']
18:51:10brixenhears a loud bang and sees a flash of light
18:51:20brixenshoots himself in the head
18:52:06BrianRice-workwow
19:41:40boyscoutUpdated CI specs to RubySpec 24ce35c0. - 0967ff5 - Brian Ford
19:47:32boyscoutCI: rubinius: 0967ff5 successful: 3037 files, 11915 examples, 36157 expectations, 0 failures, 0 errors
21:10:30dbussinkevan: are you there?
21:13:26rueProbably still in .ca
21:17:35dbussinkrue: too bad, then he has to wait for something he can probably appreciate :)
21:59:21brixendbussink: I think he's back wednesday
22:00:16brixendbussink: if you see specs like 4e1605cb, don't accept them
22:00:26brixensend them to me
22:00:34brixenwe have to start cleaning this stuff up
22:01:21brixenI know that patch just follows the existing specs, but that's not going to cut it
22:14:34dbussinkbrixen: ok, well, the last thing is also mainly why i applied it
22:14:49dbussinkbrixen: and probably also why it was written this way
22:16:22brixendbussink: I'm not following you, can you elaborate?
22:16:35brixenyou mean because it was just following the existing specs?
22:24:03rueHow should it be written?